Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Allow PR title to end with a capital letter #1291

Merged
merged 2 commits into from
Apr 6, 2023
Merged

ci: Allow PR title to end with a capital letter #1291

merged 2 commits into from
Apr 6, 2023

Conversation

shahzadlone
Copy link
Member

@shahzadlone shahzadlone commented Apr 5, 2023 •
edited
Loading

Relevant issue(s)

Resolves #1236
Previous PR that was closed: #1237

Description

Allows the last character of PR title to be a capital alphabet.

Note: isn't straight forward to make back-tick work as last character, omitting that.

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

  • make test:scripts
  • And the PR title changes

@shahzadlone shahzadlone added action/no-benchmark Skips the action that runs the benchmark. area/cli Related to the CLI binary labels Apr 5, 2023
@shahzadlone shahzadlone added this to the DefraDB v0.5 milestone Apr 5, 2023
@shahzadlone shahzadlone self-assigned this Apr 5, 2023
@shahzadlone shahzadlone mentioned this pull request Apr 5, 2023
Closed
4 tasks
@shahzadlone shahzadlone requested a review from a team April 5, 2023 15:16
@shahzadlone shahzadlone changed the title ci: Make PR title validation more relaxed ci: Make PR title validation more relaxed Apr 5, 2023
@shahzadlone shahzadlone changed the title ci: Make PR title validation more relaxed ci: Make PR title validation more relaxeD Apr 5, 2023
@codecov
Copy link

codecov bot commented Apr 5, 2023 •
edited
Loading

Codecov Report

Merging #1291 (01b5fa4) into develop (055e2ea) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1291      +/-   ##
===========================================
- Coverage    70.47%   70.45%   -0.03%     
===========================================
  Files          184      184              
  Lines        17825    17825              
===========================================
- Hits         12562    12558       -4     
- Misses        4311     4314       +3     
- Partials       952      953       +1

see 2 files with indirect coverage changes

@shahzadlone shahzadlone force-pushed the orpheus/ci/relax-pr-title-validation branch from cce67e1 to ab2e545 Compare April 5, 2023 15:27
@shahzadlone shahzadlone changed the title ci: Make PR title validation more relaxeD ci: Make PR title validation more relaxed` Apr 5, 2023
@shahzadlone shahzadlone changed the title ci: Make PR title validation more relaxed` ci: Make PR title validation more relaxed Apr 5, 2023
@shahzadlone shahzadlone force-pushed the orpheus/ci/relax-pr-title-validation branch from ab2e545 to d2286f8 Compare April 5, 2023 16:00
@shahzadlone shahzadlone changed the title ci: Make PR title validation more relaxed ci: Make PR title validation more relaxeD Apr 5, 2023
@shahzadlone shahzadlone changed the title ci: Make PR title validation more relaxeD ci: Allow PR title to end with a capital letter Apr 5, 2023
fredcarle
fredcarle approved these changes Apr 6, 2023
View reviewed changes
Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahzadlone shahzadlone force-pushed the orpheus/ci/relax-pr-title-validation branch from d2286f8 to 01b5fa4 Compare April 6, 2023 17:38
@shahzadlone shahzadlone merged commit 1ad33e5 into develop Apr 6, 2023
@shahzadlone shahzadlone deleted the orpheus/ci/relax-pr-title-validation branch April 6, 2023 17:56
shahzadlone added a commit that referenced this pull request Apr 13, 2023
@shahzadlone
ci: Allow PR title to end with a capital letter (#1291)
818bed8 
- Resolves #1236

- Description: Allows the last character of PR title to be a capital alphabet.
shahzadlone added a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@shahzadlone
ci: Allow PR title to end with a capital letter (sourcenetwork#1291)
9e37be5 
- Resolves sourcenetwork#1236

- Description: Allows the last character of PR title to be a capital alphabet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredcarle fredcarle fredcarle approved these changes

Assignees

@shahzadlone shahzadlone

Labels
action/no-benchmark Skips the action that runs the benchmark. area/cli Related to the CLI binary
Projects
None yet
Milestone
DefraDB v0.5
Development

Successfully merging this pull request may close these issues.

PR title validation too strict
2 participants
@shahzadlone @fredcarle